Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default tensor size guidance for text #1276

Closed
wants to merge 2 commits into from

Conversation

bhack
Copy link

@bhack bhack commented Jul 11, 2018

No description provided.

@nfelt
Copy link
Contributor

nfelt commented Jul 20, 2018

@bhack could you explain the motivation for this change? I believe by default the text plugin will use the TENSORS entry from DEFAULT_SIZE_GUIDANCE which is also 10, so this change would seem to be a no-op.

Also, I think to get the tests to pass you would need to add a dependency on the text_plugin to the application build target here:
https://github.com/bhack/tensorboard/blob/7ab07620a83c640c1b482fa2e3a6f8a4775e892e/tensorboard/backend/BUILD#L57-L73

@bhack
Copy link
Author

bhack commented Jul 20, 2018

Cause you cannot control the sampling from the interface i have some text data correlated to the images. So as the image has its own entry when I change it I want to change text with the same value without change the default for all.

Add test_plugin deps
@nfelt
Copy link
Contributor

nfelt commented Jul 20, 2018

@bhack as of TensorBoard 1.9.0 there's a --samples_per_plugin flag you can use to override the default sample counts - can you just use that? See #1138 for details.

@bhack
Copy link
Author

bhack commented Jul 20, 2018

Ok it is the same. Is it the plural of the plugin name "s" suffix?

@nfelt
Copy link
Contributor

nfelt commented Jul 20, 2018

The string to use is the same as the key of the DEFAULT_TENSOR_SIZE_GUIDANCE dictionary, the PLUGIN_NAME field from the respective plugin metadata. For the text plugin it's text and for the images plugin it's images.

@bhack
Copy link
Author

bhack commented Jul 20, 2018

ok thanks

@bhack bhack closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants