[Debugger Plugin] Tensor Value Card UI Improvements #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the tensor name title clickable. When clicked, it'll highlight the node in the Graph View, the Node List, as well as the Source Code View (if open). * Hide the default "DebugIdentity" op name to reduce visual cluttering.
chihuahua
approved these changes
Mar 7, 2018
| @@ -48,6 +48,13 @@ | |||
| value: null, | |||
| }, | |||
|
|
|||
| // Callback invoked when a tensor name is clicked in one of the tensor | |||
| // value views. Set externally. | |||
| tensorNameClicked: { | |||
There was a problem hiding this comment.
If you would like this component to delay initialization til this property is defined, you can just leave out the value, ie tensorNameClicked: Object.
There was a problem hiding this comment.
Done. Thanks for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the node in the Graph View, the Node List, as well as the Source
Code View (if open).