Skip to content

Commit

Permalink
readme: remove reference to backend/application.py
Browse files Browse the repository at this point in the history
Summary:
Before `--samples_per_plugin` existed, the only way to change the
sampling thresholds was to patch `application.py` manually. But the flag
has been the right way to do this since #1138, and manual patching has
been insufficient since the flag value was exposed to plugins in #3271.
There’s no need to discuss this implementation detail any more.

wchargin-branch: readme-remove-application-reference
wchargin-source: b79027ec8b279537bdf38f7b5d7f36cf5dd38498
  • Loading branch information
wchargin committed Aug 18, 2020
1 parent 6125a85 commit a5b863b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,7 @@ TensorBoard uses [reservoir
sampling](https://en.wikipedia.org/wiki/Reservoir_sampling) to downsample your
data so that it can be loaded into RAM. You can modify the number of elements it
will keep per tag by using the `--samples_per_plugin` command line argument (ex:
`--samples_per_plugin=scalars=500,images=20`). Alternatively, you can change the
source code in
[tensorboard/backend/application.py](tensorboard/backend/application.py).
`--samples_per_plugin=scalars=500,images=20`).
See this [Stack Overflow question](http://stackoverflow.com/questions/43702546/tensorboard-doesnt-show-all-data-points/)
for some more information.

Expand Down

0 comments on commit a5b863b

Please sign in to comment.