Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14 #172

Merged
merged 25 commits into from
Oct 9, 2021
Merged

0.14 #172

merged 25 commits into from
Oct 9, 2021

Conversation

owenvallis
Copy link
Collaborator

No description provided.

ebursztein and others added 24 commits September 22, 2021 23:05
* working verison ish

* faster sampler

* Remove quickdraw notebooks.

Co-authored-by: Owen Vallis <ovallis@google.com>
* Make get_examples() -> _get_examples()
* Update doc strings to refer to classes_per_batch and examples_per_class_per_batch
* Update notebook to also use examples_per_class
* Update Return types of _get_examples() and generate_batch() to use FloatTensor and IntTensor
* Fix get_slice in tfds sampler
* other small sampler fixes
… faster for loop over lists and convert to np.array

* Improve docstring coverage
* Basic formatting using yamf
* Reorder top level imports in __init__
#169)

* Raise errors if users try to evaluate over an empty index or pass an empty set of lookupd to the evaluators.

* Add hints to index Exceptions.
num_examples_per_class. In that case, we warn the user and then
sample with replacement. The warning will only be printed once per
class.

Also fixed a mypy error in the img_augments.py module.
* Enforce that class_mapping is map by calling .get() and move the class_label code into it's own function.

* Update hello world to remove class_mapping from viz_neighbors_imgs as we can just use the class ids.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@owenvallis owenvallis merged commit 9803dc3 into master Oct 9, 2021
@owenvallis owenvallis deleted the 0.14 branch October 9, 2021 00:35
abeltheo pushed a commit to abeltheo/similarity that referenced this pull request Mar 23, 2023
* Better sampler (tensorflow#160)

* working verison ish

* faster sampler

* Remove quickdraw notebooks.

Co-authored-by: Owen Vallis <ovallis@google.com>

* * Add get_slice to SingleShotMemorySampler
* Make get_examples() -> _get_examples()
* Update doc strings to refer to classes_per_batch and examples_per_class_per_batch
* Update notebook to also use examples_per_class
* Update Return types of _get_examples() and generate_batch() to use FloatTensor and IntTensor

* Set version to 0.14

* Run workflow on push for master only and on pull_request for all branches.

* Add create_index method to enable setting an index outside of the compile call. (tensorflow#164)

fix tensorflow#163

* * Add sampler_io_cookbook notebook
* Fix get_slice in tfds sampler
* other small sampler fixes

* Remove randomflip from mnist augmentation in sampler cookbook.

* Add link to sampler notebook in examples readme.

* * Remove tf.gather from memory_samplers._get_examples(). Replace with faster for loop over lists and convert to np.array
* Improve docstring coverage
* Basic formatting using yamf
* Reorder top level imports in __init__

* Update batch info when initializing sampler to better reflect the initial batch size and number of augmenters.

* kaggle first

* Raise errors if users try to evaluate over an empty index or pass an … (tensorflow#169)

* Raise errors if users try to evaluate over an empty index or pass an empty set of lookupd to the evaluators.

* Add hints to index Exceptions.

* Make batch size msg clearer.

* MultiSampler now samples without replacement unless the class size is <
num_examples_per_class. In that case, we warn the user and then
sample with replacement. The warning will only be printed once per
class.

Also fixed a mypy error in the img_augments.py module.

* Update SimilarityModel.compile() arg order to be consistent with the
Keras Model.compile().

* Enforce that class_mapping is map by calling .get() and move the class_label code into it's own function.

* Update hello world to remove class_mapping from viz_neighbors_imgs as we can just use the class ids.

* Ensure class mapping in nn_viz requires a dict (tensorflow#170)

* Enforce that class_mapping is map by calling .get() and move the class_label code into it's own function.

* Update hello world to remove class_mapping from viz_neighbors_imgs as we can just use the class ids.

* Add support for passing distance thresholds and matcher in callbacks.

* Update new for 0.14 in README

Co-authored-by: Elie Bursztein <github@elie.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants