NCF XLA and Eager tests with a refactor of resnet flags to make this cleaner. #7067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptapriya
approved these changes
Jun 20, 2019
|
Test failures are Transformer. I fixed all ResNet unit tests failures. Hopefully I or we can clean up the transformer issues soon as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: I am sorry this got big. What happened is to move run_eagerly as a based flag Resnet flag usage needed refactored. And I wanted to do it anyway to reduce our calls to resnet_run_loop from the TF 2.0/Keras code.
I have run ResNet50 and ResNet56 1 GPU tests benchmark.*1_gpu and for ResNet50 benchmark.*8_gpu and then the NCF tests.
Very soon I will factor out the rest of the calls to imagenet_main.py from the v2 folder so we can more easily move the v1 code into some archive folder. I think only the constants are left.