TF 2.0 Transformer: Remove metrics hack #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfboyd
approved these changes
Jun 5, 2019
| self.vocab_file = os.path.join(temp_dir, "vocab") | ||
| self.vocab_size = misc.get_model_params(FLAGS.param_set, 0)["vocab_size"] | ||
| self.bleu_source = os.path.join(temp_dir, "bleu_source") | ||
| self.bleu_ref = os.path.join(temp_dir, "bleu_ref") | ||
|
|
||
| def _assert_exists(self, filepath): | ||
| self.assertTrue(os.path.exists(filepath)) | ||
|
|
||
| def test_train(self): |
There was a problem hiding this comment.
#1 thank you for working on these tests.
Question, do we need this test if we are not checking anything? My assumption is we will catch exceptions via the other tests. Not remotely against the test just asking.
There was a problem hiding this comment.
Hm, these tests are basically verifying that we get to the end of train without running into any errors.
I don't know of any other tests that verify this for transformer, are there any?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue has been fixed so we can now create and update metrics in cross replica context.
Also fixed existing unit tests and added more tests which test distribution strategy codepaths as well.