-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ModelCardGenerator component #248
Deprecate ModelCardGenerator component #248
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Suzen Fylke <codesue@users.noreply.github.com> Co-authored-by: Hannes Hapke <hanneshapke@users.noreply.github.com>
a938378
to
21873ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, an idea here may be to try to import the component from tfx-addons:
try:
from tfx-addons.model_card_generator import ModelCardGenerator
except ImportError:
ModelCardGenerator = None
This way users can optionally install tfx-addons and still continue using the component without breakage. it's a bit complex to be fair, so not 100% sure about it, but may be worth a shot
Apparently this branch was set up to automatically dismiss PR approvals when new commits are pushed. Just changed it to not do that. 😅 |
@codesue Do you mind keeping the |
@hanneshapke I changed it back. |
What does this pull request do?
ModelCardGenerator
component and thetfx
dependencytfx-addons
model-card-toolkit
will be compatible with newer versions oftfx
This change will be part of version 2.0.0.
Fixes #247, #202, #185, #93
How did you test this change?
Installed with
pip install -e ".[test]"
. Ran all tests withfind . -name '*_test.py' | xargs -I {} python {}
.See this gist for pip freeze and test output.
Note: The test added in this PR looks like it takes a long time to run, but the expensive part of that is importing
model_card_tookit
the first time. Runningtime
onmodel_card_toolkit/__init__.py
takes7.27s user 1.55s system 90% cpu 9.727 total
compared to0.06s user 0.03s system 55% cpu 0.156 total
when running the code for the added test on its own.How did you document this change?
NotImplementedError
that's raised when importing from the removed module.Before submitting
Before submitting a pull request, please be sure to do the following:
Co-authored-by: Suzen Fylke codesue@users.noreply.github.com
Co-authored-by: Hannes Hapke hanneshapke@users.noreply.github.com