Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: GELU name #843

Merged
merged 2 commits into from
Jan 9, 2020
Merged

FIX: GELU name #843

merged 2 commits into from
Jan 9, 2020

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jan 9, 2020

Correct the abbreviation from GeLU to GELU, which is used in the original paper and the community.

@boring-cyborg boring-cyborg bot added the layers label Jan 9, 2020
@WindQAQ
Copy link
Member Author

WindQAQ commented Jan 9, 2020

cc @AakashKumarNain

@WindQAQ WindQAQ requested review from a team and removed request for facaiy and seanpmorgan January 9, 2020 06:45
@AakashKumarNain
Copy link
Member

Thanks @WindQAQ . I still don't understand how we missed this for so long..lol

seanpmorgan
seanpmorgan approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... I think at this point in repository usage we're okay without an alias here, but in the future we'll probably need to.

@seanpmorgan seanpmorgan merged commit 06d686e into tensorflow:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes layers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WindQAQ @AakashKumarNain @seanpmorgan @googlebot