Translate ops added and its test script #320

sayoojbk · 2019-06-27T17:25:57Z

The translate ops and the test scripts have been added for the issue #25

googlebot · 2019-06-27T17:26:00Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

sayoojbk · 2019-06-27T17:29:52Z

I signed it!

googlebot · 2019-06-27T17:29:54Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

WindQAQ

Hi @sayoojbk , thanks for the contribution here! I drop some comments below. Some files should be modified too:

If you want to be a submodule maintainer, please feel free to drop your name on README

There are some errors and wrong formats so do not forget to run make to execute sanity check and tests before committing the codes. Thanks for the contribution again :P

tensorflow_addons/image/translate_ops_test.py

tensorflow_addons/image/translate_ops.py

tensorflow_addons/image/translate_ops_test.py

sayoojbk

I made most of the changes that you suggested but not sure about this one :#320 (comment) . Like do I need to remove the session from this and keep this function in a Python function format.

kyleabeauchamp · 2019-06-28T05:28:55Z

I think the comment was just suggesting that you delete the line with self.cached_session():, which you appear to have done.

sayoojbk · 2019-06-28T05:36:17Z

I think the comment was just suggesting that you delete the line with self.cached_session():, which you appear to have done.

Ohh thanks and are there any other changes you think to be made yet.

WindQAQ

@sayoojbk , LGTM! Only some minor changes and a unit test for translations_to_projective_transforms are needed.

WindQAQ · 2019-07-01T16:14:21Z

tensorflow_addons/image/README.md

@@ -8,6 +8,8 @@
 | distort_image_ops | @WindQAQ | windqaq@gmail.com |
 | filters | @Mainak431 | mainakdutta76@gmail.com |
 | transform_ops | @mels630 | mels630@gmail.com | 
+| translate_ops | @sayoojbk	| sayoojbk@gmail.com |
+| translations_to_projective_transforms | @sayoojbk	| sayoojbk@gmail.com |


Remove this line :P

WindQAQ · 2019-07-01T16:18:03Z

tensorflow_addons/image/README.md

@@ -8,6 +8,8 @@
 | distort_image_ops | @WindQAQ | windqaq@gmail.com |
 | filters | @Mainak431 | mainakdutta76@gmail.com |
 | transform_ops | @mels630 | mels630@gmail.com | 
+| translate_ops | @sayoojbk	| sayoojbk@gmail.com |
+| translations_to_projective_transforms | @sayoojbk	| sayoojbk@gmail.com |

 ## Components 
 | Submodule  | Image Processing Function |  Reference  |


I have added them alphabetically and removed the line containing the name I added.

Oops, I mean we only have to remove this line

| translations_to_projective_transforms | @sayoojbk | sayoojbk@gmail.com |

WindQAQ · 2019-07-01T16:22:00Z

tensorflow_addons/image/translate_ops_test.py

+            self.assertAllEqual(
+                self.evaluate(image_translated),
+                [[1, 0, 1, 0], [0, 1, 0, 0], [1, 0, 1, 0], [0, 0, 0, 0]])
+


Would you mind doing a unit test for translations_to_projective_transforms? Sorry about not requesting this earily. I am not aware that it is also a public API too.

SSaishruthi · 2019-07-01T18:57:54Z

@WindQAQ
I think the name has been changed. Is that me you are pointing to?

WindQAQ · 2019-07-01T19:28:38Z

@SSaishruthi Sorry about that... I mean @sayoojbk instead.

WindQAQ

Great! Thanks for the contribution again!

translate ops added and its test script

0980ab4

sayoojbk requested review from facaiy and WindQAQ as code owners June 27, 2019 17:25

googlebot added the cla: no label Jun 27, 2019

googlebot added cla: yes and removed cla: no labels Jun 27, 2019

WindQAQ requested changes Jun 27, 2019

View reviewed changes

Update translate_ops.py

da99502

facaiy added kokoro:force-run image labels Jun 27, 2019

kokoro-team removed the kokoro:force-run label Jun 27, 2019

sayoojbk added 3 commits June 28, 2019 10:50

Update translate_ops_test.py

afb7691

Update translate_ops.py

b3ac620

Update translate_ops.py

8f1f3e6

sayoojbk commented Jun 28, 2019

View reviewed changes

sayoojbk and others added 4 commits June 29, 2019 21:47

Added @sayoojbk submodule maintainer of translate ops

a181d90

Update BUILD

988f82c

Update __init__.py for the addition of translate ops

9ae08f1

applied patch provided by @WindQAQ to resolve conflicts

48effea

WindQAQ self-requested a review July 1, 2019 16:13

WindQAQ requested changes Jul 1, 2019

View reviewed changes

sayoojbk and others added 2 commits July 2, 2019 16:06

Update README.md

e049dbc

test case done for translations_to_projective_transforms

61bf00a

sayoojbk added 2 commits July 5, 2019 21:49

update readme

f37110f

removing merge error messages

8f354b7

WindQAQ added the kokoro:force-run label Jul 5, 2019

kokoro-team removed the kokoro:force-run label Jul 5, 2019

WindQAQ self-requested a review July 5, 2019 18:33

WindQAQ approved these changes Jul 5, 2019

View reviewed changes

WindQAQ merged commit dfd0c66 into tensorflow:master Jul 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translate ops added and its test script #320

Translate ops added and its test script #320

sayoojbk commented Jun 27, 2019

googlebot commented Jun 27, 2019

sayoojbk commented Jun 27, 2019

googlebot commented Jun 27, 2019

WindQAQ left a comment

sayoojbk left a comment

kyleabeauchamp commented Jun 28, 2019

sayoojbk commented Jun 28, 2019

WindQAQ left a comment •

edited

Loading

WindQAQ Jul 1, 2019

WindQAQ Jul 1, 2019

sayoojbk Jul 2, 2019

WindQAQ Jul 2, 2019

WindQAQ Jul 1, 2019

SSaishruthi commented Jul 1, 2019

WindQAQ commented Jul 1, 2019

WindQAQ left a comment

Translate ops added and its test script #320

Translate ops added and its test script #320

Conversation

sayoojbk commented Jun 27, 2019

googlebot commented Jun 27, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

sayoojbk commented Jun 27, 2019

googlebot commented Jun 27, 2019

WindQAQ left a comment

Choose a reason for hiding this comment

sayoojbk left a comment

Choose a reason for hiding this comment

kyleabeauchamp commented Jun 28, 2019

sayoojbk commented Jun 28, 2019

WindQAQ left a comment • edited Loading

Choose a reason for hiding this comment

WindQAQ Jul 1, 2019

Choose a reason for hiding this comment

WindQAQ Jul 1, 2019

Choose a reason for hiding this comment

sayoojbk Jul 2, 2019

Choose a reason for hiding this comment

WindQAQ Jul 2, 2019

Choose a reason for hiding this comment

WindQAQ Jul 1, 2019

Choose a reason for hiding this comment

SSaishruthi commented Jul 1, 2019

WindQAQ commented Jul 1, 2019

WindQAQ left a comment

Choose a reason for hiding this comment

WindQAQ left a comment •

edited

Loading