Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support for Apple Silicon. #2718

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

sun1638650145
Copy link
Contributor

@sun1638650145 sun1638650145 commented May 31, 2022

Description

tensorflow-macos already supports Python 3.10, so add Python 3.10 support in Apple Silicon.

Fixes #2715

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

No new test cases are required, just a new whl file is added.

@boring-cyborg boring-cyborg bot added the github label May 31, 2022
@seanpmorgan
Copy link
Member

Thanks @sun1638650145 ! Looks like a new protobuf version may be breaking the CI which is un-related to this PR

@bhack
Copy link
Contributor

bhack commented May 31, 2022

Do we had another patch release?

@seanpmorgan
Copy link
Member

Do we had another patch release?

Yeah I'll create a patch release, but we need to fix CI for importing TF first

@bhack
Copy link
Contributor

bhack commented May 31, 2022

I meant that we have TF 2.9.1

https://github.com/tensorflow/tensorflow/releases/tag/v2.9.1

@sun1638650145
Copy link
Contributor Author

@seanpmorgan I see you submitted this PR #2721, should I wait until this PR is merged before proceeding?

@seanpmorgan
Copy link
Member

@seanpmorgan I see you submitted this PR #2721, should I wait until this PR is merged before proceeding?

Yes, we can't make a patch release until we get the build fixed. Should be soon.

@seanpmorgan
Copy link
Member

Hi @sun1638650145 build is fixed. Please rebase on master

@sun1638650145
Copy link
Contributor Author

Two tests failed due to timeout, is there a way to rerun it?

@sun1638650145
Copy link
Contributor Author

All tests passed!

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit aa88b70 into tensorflow:master Jun 6, 2022
@seanpmorgan
Copy link
Member

Thanks @sun1638650145 ! Could you make the same PR for r0.17 branch please?

@sun1638650145
Copy link
Contributor Author

@seanpmorgan No problem, a PR for r0.17 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for Python 3.10 Support for Arm64
3 participants