Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to restore AdaBelief optimizer from checkpoint #2705

Merged
merged 2 commits into from
May 18, 2022

Conversation

denadai2
Copy link
Contributor

@denadai2 denadai2 commented May 18, 2022

Description

Brief Description of the PR:
This PR solves the same issue reported in #2361, by avoiding storing a int32 variable.

Type of change

  • Bug fix

Checklist:

@bot-of-gabrieldemarmiesse

@juntang-zhuang

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@denadai2 denadai2 changed the title Update adabelief.py Failing to restore AdaBelief optimizer from checkpoint May 18, 2022
Copy link
Contributor

@bhack bhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the checkpoint test here as in:

https://github.com/tensorflow/addons/pull/2369/files

@denadai2 denadai2 requested a review from bhack May 18, 2022 13:52
@bhack bhack merged commit 953d848 into tensorflow:master May 18, 2022
@denadai2
Copy link
Contributor Author

Thanks @bhack! When do you think it will be possible to have a release of tensorflow addons so that it is possible to have AdaBelief in production? The nightly version might not be accepted in my company :)

thx

@denadai2 denadai2 deleted the patch-2 branch May 19, 2022 10:50
@bhack
Copy link
Contributor

bhack commented May 19, 2022

You can subscribe to #2696

@juntang-zhuang
Copy link
Contributor

LGTM, thanks for fixing the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants