Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTOTUNE 'y_shape' #2702

Merged
merged 4 commits into from
May 16, 2022
Merged

AUTOTUNE 'y_shape' #2702

merged 4 commits into from
May 16, 2022

Conversation

markub3327
Copy link
Contributor

Hello,

y_shape can be determine automatically, not manually typed by user.

Thanks.

@bot-of-gabrieldemarmiesse
Copy link

@SSaishruthi @marload

You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@bhack
Copy link
Contributor

bhack commented May 16, 2022

Can you keep the arg and emit a deprecation if passed? So that we don't brake the API so fast.

We have deprecation examples in the source code

@markub3327
Copy link
Contributor Author

@bhack

Ok. I added a warning about it.

bhack
bhack requested changes May 16, 2022
View reviewed changes
tensorflow_addons/metrics/r_square.py Outdated Show resolved Hide resolved
@markub3327 markub3327 requested a review from bhack May 16, 2022 15:33
@bhack bhack merged commit fe9c9dd into tensorflow:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhack bhack bhack approved these changes

Assignees
No one assigned
Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markub3327 @bot-of-gabrieldemarmiesse @bhack