Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add T=bfloat16 to custom_ops registration #2688

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Add T=bfloat16 to custom_ops registration #2688

merged 2 commits into from
Apr 12, 2022

Conversation

szutenberg
Copy link
Contributor

Description

Brief Description of the PR:

This issue adds T=bfloat16 wherever it's relevant. The reason is that I want to add bfloat16 support of addons to my custom accelerator. It's not possible to register kernel for T=bfloat16 if op registration doesn't have it.

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

build passes

@bhack
Copy link
Contributor

bhack commented Apr 11, 2022

You need to fix format.

@szutenberg
Copy link
Contributor Author

Hi @bhack ,

I followed the instruction from STYLE_GUIDE.md. I see that there are issues with Python formatting but I didn't change any Python code.

Clang C++ code format passes.

Where do you see formatting issues?

@bhack
Copy link
Contributor

bhack commented Apr 11, 2022

Yes it Is on python and not related

@bhack bhack requested review from seanpmorgan and bhack April 11, 2022 17:55
@bhack
Copy link
Contributor

bhack commented Apr 11, 2022

@szutenberg Can you rebase this?

@bhack bhack merged commit c585796 into tensorflow:master Apr 12, 2022
@szutenberg szutenberg deleted the bfloat16 branch April 12, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants