Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hardshrink.py #2649

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Update hardshrink.py #2649

merged 1 commit into from
Jan 18, 2022

Conversation

jvishnuvardhan
Copy link
Contributor

Currently the page https://www.tensorflow.org/addons/api_docs/python/tfa/activations/hardshrink?hl=de_DE is not rendered properly because of a missing backtick.

Added a backtick to format and render the page correctly

Description

Brief Description of the PR:

Fixes # (issue)

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

Currently the page https://www.tensorflow.org/addons/api_docs/python/tfa/activations/hardshrink?hl=de_DE is not rendered properly because of a missing backtick.
 
Added a backtick to format and render the page correctly
@bhack bhack merged commit 3f2f7a1 into tensorflow:master Jan 18, 2022
@bhack
Copy link
Contributor

bhack commented Jan 18, 2022

Thanks

@jvishnuvardhan jvishnuvardhan deleted the patch-2 branch January 18, 2022 23:56
@jvishnuvardhan
Copy link
Contributor Author

Thanks
@bhack
I am not sure why the TF page is pointing to 0.15 version instead of master. I have updated only on master source code. Should I update it on 0.15 version also?

@bhack
Copy link
Contributor

bhack commented Jan 19, 2022

I don't know the deploy machinery for Docs. We need to ask to @lamberta

@lamberta
Copy link
Member

Hello. I'm working on another project these days but @MarkDaoust and @markmcd can help

@MarkDaoust
Copy link
Member

TF page is pointing to 0.15 version instead of master.

tensorflow.org documents the latest stable release. This update will get pulled into the site after the next release.

I have updated only on master source code. Should I update it on 0.15 version also?

No. We only update master. The version tags/branches should be considered frozen.

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants