Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In LAMB optimizer, rename weight_decay_rate to weight_decay #2611

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

ksachdeva
Copy link
Contributor

Description

Brief Description of the PR:

Fixes #2610

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

By writing a unit test

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

  • Ran pytest

@bot-of-gabrieldemarmiesse

@junjiek

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@bhack
Copy link
Contributor

bhack commented Nov 20, 2021

Tests are failing

@ksachdeva
Copy link
Contributor Author

The tests are passing but seems to be an issue with wheel building on Ubuntu.

bhack
bhack previously approved these changes Nov 20, 2021

if "weight_decay_rate" in kwargs:
warnings.warn(
"weight_decay_rate has been renamed to weight_decay",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Palese claim an Addons version as in the PR example I've mentioned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@bhack bhack merged commit 41eaa27 into tensorflow:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LAMB Optimizer - rename weight_decay_rate to weight_decay
3 participants