Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty batches in ResamplerOp #2219

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Conversation

crccw
Copy link
Member

@crccw crccw commented Oct 27, 2020

Description

Empty batches are possible in distributed synchronous training. If some
replicas have run out of data while some haven't, tf.distribute produces
empty batches so that the training can proceed.

Fixes # (issue)

Type of change

  • Bug fix

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

unit test


This change is Reviewable

Empty batches are possible in distributed synchronous training. If some
replicas have run out of data while some haven't, tf.distribute produces
empty batches so that the training can proceed.
@bot-of-gabrieldemarmiesse

@autoih

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@seanpmorgan seanpmorgan merged commit 51e541b into tensorflow:master Nov 1, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants