Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM architecture build from source #2182

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

seanpmorgan
Copy link
Member

Description

Add support for building from source for ARM64 architectures. Requests for this can be seen in #1982

Type of change

  • Build improvement

Checklist:

@WindQAQ
Copy link
Member

WindQAQ commented Sep 29, 2020

Is there any way to test arm build on CI?

@bhack
Copy link
Contributor

bhack commented Sep 29, 2020

tensorflow/build#9

@bhack
Copy link
Contributor

bhack commented Sep 29, 2020

Also, if you want to track devcontainer/codespace for our images on this Arch please subscribe to microsoft/vscode-dev-containers#558

@bhack
Copy link
Contributor

bhack commented Sep 29, 2020

/cc @bzhaoopenstack is there a way to add support for Addons CI/builds/wheels for ARM64 on your infra?

An alternative could be to use Qemu Github Action but it will be quite slow in emulation: https://github.com/uraimo/run-on-arch-action

@WindQAQ WindQAQ self-requested a review September 30, 2020 16:40
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you for the info @bhack! Seems that it's not an easy work. I prefer that we can work on it after this!

@WindQAQ WindQAQ merged commit 07ed7ac into tensorflow:master Sep 30, 2020
@seanpmorgan seanpmorgan deleted the add-arm-build branch September 30, 2020 16:48
@seanpmorgan
Copy link
Member Author

LGTM.

Thank you for the info @bhack! Seems that it's not an easy work. I prefer that we can work on it after this!

Yeah we also have PowerPC builds enabled, but untested because of the same reason.

jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants