Add a warning when trying to load a custom op with a uncompatible version of TF. #1482
Conversation
|
I believe we can add more info in the readme. Let's not bload the warning too much, it's already very descriptive. |
| "https://github.com/tensorflow/addons#gpucpu-custom-ops " | ||
| "\n\n" | ||
| "You can also change the TensorFlow version installed on your system. " | ||
| "You would need a TensorFlow version equal to or above {} and strictly " |
There was a problem hiding this comment.
Can you add "installed from pip" somewhere in there. I suspect that is just as likely of an issue as incompatible version
There was a problem hiding this comment.
I'll add it. But this warning won't appear if someone is building from source. I don't know if there is any way we can detect that. If TF was exposing an API to get info about the build, we could use that. As far as I know, such an API doesn't exist.
There was a problem hiding this comment.
I don't believe so. If there was it would be in https://www.tensorflow.org/api_docs/python/tf/sysconfig most likely
| "https://github.com/tensorflow/addons#gpucpu-custom-ops " | ||
| "\n\n" | ||
| "You can also change the TensorFlow version installed on your system. " | ||
| "You would need a TensorFlow version equal to or above {} and strictly " |
There was a problem hiding this comment.
I don't believe so. If there was it would be in https://www.tensorflow.org/api_docs/python/tf/sysconfig most likely
…sion of TF. (tensorflow#1482) * Fixing the gpu build. * Add a warning when trying to load a custom op. * Add also the nightly version. * Better formatting. * Update message. * Added message about non-pip TF.
First step towards fixing #1317