Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more shapes in FilterResponseNormalization #1441

Closed
Squadrick opened this issue Mar 26, 2020 · 4 comments
Closed

Add support for more shapes in FilterResponseNormalization #1441

Squadrick opened this issue Mar 26, 2020 · 4 comments
Labels
Feature Request good first issue help wanted Needs help as a contribution layers

Comments

@Squadrick
Copy link
Member

#765 added FRN to TFA.

Currently, tfa.layers.FilterResponseNormalization only support 4D tensors of order NHWC. We need to add support for arbitrary tensors and let the user specify the axis/axes to normalize over. (axes currently is forced to be [1, 2]).

See the TODO in tensorflow_addons/layers/normalizations.py.

BLOCKED: Till #765 is merged.
@Squadrick Squadrick added help wanted Needs help as a contribution layers good first issue blocked Pending something elses completion Feature Request labels Mar 26, 2020
@Squadrick Squadrick mentioned this issue Mar 26, 2020
Merged
@Opletts
Copy link

Opletts commented Mar 29, 2020

@Squadrick I'll take this up.

@Squadrick Squadrick removed the blocked Pending something elses completion label Mar 29, 2020
@Suraj-Upadhyay
Copy link

Hii Guys, I am working on this. Currently reading the research paper for Filter Response Normalization.

If in any doubts I will post it in the comments here and I hope to send a PR soon.

@Opletts
Copy link

Opletts commented Feb 15, 2021

Sorry guys, I completely forgot about this issue! I have #1496 open and I'll finish it this week.

Opletts added a commit to Opletts/addons that referenced this issue Feb 19, 2021
@Opletts
Added tests for FRN on N-D tensors, fixes tensorflow#1441
55a3001 
* Tests for 3D-7D tensors
* Error raised when tensors aren't at least 3D
@seanpmorgan
Copy link
Member

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request good first issue help wanted Needs help as a contribution layers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanpmorgan @Squadrick @Opletts @Suraj-Upadhyay