Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v1): disable diff/merge op for moby builder #1699

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat(v1): disable diff/merge op for moby builder #1699

merged 3 commits into from
Jul 11, 2023

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jul 10, 2023 •
edited
Loading

This will disable diff/merge op if it's using the moby builder.

Other changes:

  • fix the config.jupyter in v1
  • fix installing multiple languages
    • previous it will omit python since it's not added to the packs

TBD:

  • Should we use moby by default?

cc @gaocegege @pingsutw

@kemingy
feat(v1): disable diff/merge op for moby builder
f6a26da 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy
add e2e moby test
78273cf 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy
fix lint
c3f1303 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@pingsutw
Copy link
Member

@kemingy thanks, let me test it first, I'll get back to you.

@gaocegege gaocegege enabled auto-merge July 11, 2023 15:09
@gaocegege gaocegege added this pull request to the merge queue Jul 11, 2023
Merged via the queue into tensorchord:main with commit 0ff9405 Jul 11, 2023
15 checks passed
@kemingy kemingy deleted the disable_merge branch July 11, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

@VoVAllen VoVAllen Awaiting requested review from VoVAllen VoVAllen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: disable buildkit merge op when using moby builder
3 participants
@kemingy @pingsutw @gaocegege