This repository has been archived by the owner on May 26, 2023. It is now read-only.
Support codec endpoint templating and more flexible codecs #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for use cases like compression where the codec may compress multiple payloads into one.
Merged
feedmeapples
approved these changes
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Support
{namespace}templating in endpoint URL and send X-Namespace header. Don't assume that the payload count returned from the codec server will match what we sent.Why?
This allows for URL separation of encoders for different namespaces as encouraged by our sample code server. This is inline with the tctl support in temporalio/tctl#161.
Also no longer assume that payload count will be consistent before/after decoding as some codecs may benefit from mapping multiple payloads into one (for example, better compression ratios).
Checklist
Tested against the remote codec server in samples-go.