Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Commit

Permalink
Support codec endpoint templating and more flexible codecs (#444)
Browse files Browse the repository at this point in the history
* Support namespace templating and header.

* Don't assume payload counts match before/after decoding.

This allows for use cases like compression where the codec may compress multiple payloads into one.
  • Loading branch information
robholland authored Mar 29, 2022
1 parent b0c3922 commit f04ba51
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
11 changes: 7 additions & 4 deletions client/features/data-conversion.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import WebSocketAsPromised from 'websocket-as-promised';

export const convertEventPayloadsWithRemoteEncoder = async (events, endpoint) => {
const headers = { 'Content-Type': 'application/json' };
export const convertEventPayloadsWithRemoteEncoder = async (namespace, events, endpointTemplate) => {
const headers = { 'Content-Type': 'application/json', 'X-Namespace': namespace };
const requests = [];
const endpoint = endpointTemplate.replaceAll('{namespace}', namespace);

events.forEach(event => {
let payloadsWrapper;
Expand All @@ -25,11 +26,13 @@ export const convertEventPayloadsWithRemoteEncoder = async (events, endpoint) =>
decodedPayloads.forEach((payload, i) => {
let data = window.atob(payload.data);
try {
payloadsWrapper.payloads[i] = JSON.parse(data);
decodedPayloads[i] = JSON.parse(data);
} catch {
payloadsWrapper.payloads[i] = data;
decodedPayloads[i] = data;
}
});

payloadsWrapper.payloads = decodedPayloads
})
.catch(() => {
payloadsWrapper.payloads.forEach((payload) => {
Expand Down
2 changes: 1 addition & 1 deletion client/routes/workflow/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export default {
}
if (endpoint !== undefined) {
return convertEventPayloadsWithRemoteEncoder(events, endpoint).catch(error => {
return convertEventPayloadsWithRemoteEncoder(this.namespace, events, endpoint).catch(error => {
console.error(error);
this.$emit('onNotification', {
Expand Down

0 comments on commit f04ba51

Please sign in to comment.