Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Extend Temporal API error messages #400

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Extend Temporal API error messages #400

merged 1 commit into from
Oct 25, 2021

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Oct 19, 2021

What was changed

Extends Temporal API calls error messages with:

  • name of the method/API
  • req data

Why?

  • helps with error reporting and debugging

Checklist

  1. Closes

  2. How was this tested:

image

image

  • shut down temporal service
  • verified the error messages contain additional data
  1. Any docs updates needed?

@stevekinney
Copy link
Member

Can we also add the API endpoint that failed?

@feedmeapples
Copy link
Contributor Author

feedmeapples commented Oct 25, 2021

Can we also add the API endpoint that failed?

the method name corresponds 1-to-1 to the API endpoint. It may be named slightly different (typically a shorter name), ex

TemporalClient.prototype.describeNamespace = async function(

the actual API name is hidden in the auto-generated code and is not available here

@feedmeapples feedmeapples merged commit fc9a8b4 into master Oct 25, 2021
@feedmeapples feedmeapples deleted the extend-error branch October 25, 2021 18:50
feedmeapples added a commit that referenced this pull request Mar 1, 2022
* Bump tar from 4.4.13 to 4.4.15 (#368)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.13...v4.4.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump path-parse from 1.0.6 to 1.0.7 (#370)

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Support refreshing TLS certs in background (#369)

* Fix gRPC connection failure in insecure connection (#374)

* Show workflow state transitions (#375)

* Bump tar from 4.4.15 to 4.4.19 (#382)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.15...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support for built-in HTTPS (#379)

* adding support for running temporal web using HTTPS based on ENV vars

* Link to new executions for more event types (#380)

* Rename left over task list -> queue (#389)

* Add maintenance mode notification in readme (#390)

* Add maintenance mode notification in readme

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: swyx <shawnthe1@gmail.com>

* Fix history exported JSON formatting (#392)

* Make header namespace link always clickable (#393)

* Bump tmpl from 1.0.4 to 1.0.5 (#395)

Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump prismjs from 1.24.0 to 1.25.0 (#394)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update proto api (#396)

* Tag Web v1.12.0 (#397)

* Added LoginRadius OAuth Doc Reference (#402)

Added LoginRadius OAuth Doc Reference to the list

* Log whether auth is enabled (#401)

* Extend Temporal API error messages (#400)

* Tag Web v1.13.0 (#407)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: arnesenfamily <arnesenfamily@users.noreply.github.com>
Co-authored-by: David Reiss <dnr@dnr.im>
Co-authored-by: swyx <shawnthe1@gmail.com>
Co-authored-by: IArchna <71074509+IArchna@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants