Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Fix gRPC connection failure in insecure connection #374

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix gRPC connection failure in insecure connection #374

merged 1 commit into from
Aug 25, 2021

Conversation

feedmeapples
Copy link
Contributor

What was changed

Fixes gRPC connection failure when mTLS certs are not passed

Why?

#369 introduced a regression when establishing insecure gRPC connection
The regression was caught by cicd pipeline

Checklist

  1. Closes

  2. How was this tested:

cicd pipeline

  1. Any docs updates needed?

mo

@feedmeapples feedmeapples enabled auto-merge (squash) August 25, 2021 22:36
@feedmeapples feedmeapples merged commit 7ae9035 into master Aug 25, 2021
@feedmeapples feedmeapples deleted the address-tclient branch August 25, 2021 22:37
feedmeapples added a commit that referenced this pull request Mar 1, 2022
@feedmeapples @dependabot
@arnesenfamily @dnr @swyxio
Merge Web v1.12.0 (#29)
b450953 
* Bump tar from 4.4.13 to 4.4.15 (#368)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.13...v4.4.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump path-parse from 1.0.6 to 1.0.7 (#370)

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Support refreshing TLS certs in background (#369)

* Fix gRPC connection failure in insecure connection (#374)

* Show workflow state transitions (#375)

* Bump tar from 4.4.15 to 4.4.19 (#382)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.15...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support for built-in HTTPS (#379)

* adding support for running temporal web using HTTPS based on ENV vars

* Link to new executions for more event types (#380)

* Rename left over task list -> queue (#389)

* Add maintenance mode notification in readme (#390)

* Add maintenance mode notification in readme

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: swyx <shawnthe1@gmail.com>

* Fix history exported JSON formatting (#392)

* Make header namespace link always clickable (#393)

* Bump tmpl from 1.0.4 to 1.0.5 (#395)

Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump prismjs from 1.24.0 to 1.25.0 (#394)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update proto api (#396)

* Tag Web v1.12.0 (#397)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: arnesenfamily <arnesenfamily@users.noreply.github.com>
Co-authored-by: David Reiss <dnr@dnr.im>
Co-authored-by: swyx <shawnthe1@gmail.com>
feedmeapples added a commit that referenced this pull request Mar 1, 2022
@feedmeapples @dependabot
@arnesenfamily @dnr @swyxio @IArchna
Merge Web v1.13.0 (#30)
cf16519 
* Bump tar from 4.4.13 to 4.4.15 (#368)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.15.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.13...v4.4.15)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump path-parse from 1.0.6 to 1.0.7 (#370)

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Support refreshing TLS certs in background (#369)

* Fix gRPC connection failure in insecure connection (#374)

* Show workflow state transitions (#375)

* Bump tar from 4.4.15 to 4.4.19 (#382)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.15...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support for built-in HTTPS (#379)

* adding support for running temporal web using HTTPS based on ENV vars

* Link to new executions for more event types (#380)

* Rename left over task list -> queue (#389)

* Add maintenance mode notification in readme (#390)

* Add maintenance mode notification in readme

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: swyx <shawnthe1@gmail.com>

* Fix history exported JSON formatting (#392)

* Make header namespace link always clickable (#393)

* Bump tmpl from 1.0.4 to 1.0.5 (#395)

Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump prismjs from 1.24.0 to 1.25.0 (#394)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update proto api (#396)

* Tag Web v1.12.0 (#397)

* Added LoginRadius OAuth Doc Reference (#402)

Added LoginRadius OAuth Doc Reference to the list

* Log whether auth is enabled (#401)

* Extend Temporal API error messages (#400)

* Tag Web v1.13.0 (#407)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: arnesenfamily <arnesenfamily@users.noreply.github.com>
Co-authored-by: David Reiss <dnr@dnr.im>
Co-authored-by: swyx <shawnthe1@gmail.com>
Co-authored-by: IArchna <71074509+IArchna@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevekinney stevekinney stevekinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @stevekinney