[DT-153] Display a canceled badge for pending activities that aren't able to run #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* standardize toast position at bottom right of screen * deprecate notifications in favor of toasts * fix broken imports * fix tests * move toast store
* signal workflow * base64 encode payload * add JSON editor component using codemirror * format * rm unused dep * format * add cy test, refresh wf after signal * allow signal workflow to be toggled on/off * add signalEnabled to workflow-run-layout * rm await tick() * fix input required indicator * move codemirror theme definitions to their own file rename JSON-editor to json-editor * rename json-editor for real * add assertion to make sure modal closes * give json editor a max height and trap scroll * reset inputs on modal close
* Add api-pagination to event-history. Need to fix onPageChange vs. onPageSizeChange which causes double fetch * More fixes/refactoring * Get arrows right, refactor * more refactoring * Remove imports * Add keyboard shortcuts * WIP: update pagination store * WIP: pagination store * More WIP: * WIP: more work * Finally fix pagination with cached items. Remove nextIndex * more stuff. need to fix reset logic * Remove initialItem from api-pagination, update reste * Key on category/refresh/sort to reload event summary * Hide bottom controls if no items * Move arrow key shortcuts out of api-pagination * Refactor, update unit tests. Need to add more, use Set * Add some color * More unit tests * Update failing unit tests * Remove unused service call, need to figure out Cypress tests * Remove unused imports * Fix all type errors, refactor import routes to work * Fix heartbeat css * Fix lint errors, export perPageSize * Add shortcut modal * Reorder keyboard shortcuts * Use const * Add dateFilterValue helper function with tests * Make all the types better for event-summary-row/details... * More helper functions with tests * Add jklh keyboard shortcuts * Add supportsReverseOrder logic and fix all the cypress tests * More refactoring, move onFetch to a derived store
* [skip actions] first pass at automating package * update bump input * don't package, only bump version * skip commit hooks * [skip actions] fix string interpolation * [skip actions] make a script for creating release * fix github actions for publishing to npm * rm unused scripts * fix env vars * fix publish package * use package.json version instead of tags
* svelte-migrate: renamed files * Complete initial migration to Sveltekit 1.0.0 * Bump to 1.0.1 of sveltekit * Fix mock for app * Update exports * Add sveltejs/package * Remove _ from holocene component names so they are added to package * Upgrade histoire and vercel-adapter * Refactor based on PR comments, remove commented out code, add type to single line imports * Add app version config to histoire * fix vite public path for histoire builds * Fix error type * Remove pollInterval in histoire * Add global var for histoire Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io> Co-authored-by: Ross Edfort <rossedfort@gmail.com>
… for updateQueryParam (#1015)
…nitiated (#1007) * Remove workflowExecution from label in event details * Get run id for workflow link on StartChildWorkflowExecutionInitiated event * Refactor to util and add unit tests * Remove child workflow execution link on StartChildWorkflowExecutionInitiated event
This builds the current UI code into Temporal CLI to run tests against.
* no ssr for login page * fix ssr disable * move login and signing Load fn to the layout move ssr disable to the layout
* Don't try to decode a null payload * Fix equality check Co-authored-by: Steve Kinney <hello@stevekinney.net> * Internal commit for Vercel Co-authored-by: Steve Kinney <hello@stevekinney.net>
* Add some docs for manually running e2e tests. * Add some scripts to make it easier for manual running.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
requested review from
Alex-Tideman and
rossedfort
and removed request for
GraceGardner
* Add back No Items slot and update api-pagination to refetch on pageSize change * Bump beta tag * Remove unused import * Add defaultPageSize prop, cleanup * Add defaults for defaultPageOption, add unit tests
* Use /holocene instead of if in holocene to fix imports of package * Fix lint * Remove all aliases * Remove rsync code and use svelte-package
rossedfort
approved these changes
Jan 9, 2023
| @@ -1,4 +1,5 @@ | |||
| <script lang="ts"> | |||
| import Badge from '$holocene/badge.svelte'; | |||
There was a problem hiding this comment.
Might have to change this import to $lib/holocene/badge.svelte according to @Alex-Tideman's PR: #1033
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
laurakwhit
deleted the
DT-153-display-a-canceled-badge-for-pending-activities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Refactor pending activities to use Table component to fix responsiveness
Add slot to Tab component and remove amount prop so we can add custom slots (e.g. custom amount badges)
If a workflow is
Timed Out,TerminatedorCanceledand there are pending activities, in the UI wePending Activitiesamount and add a canceled icon in the pending activities tabPending ActivitiessectionWhy?
Lets users know that pending activities aren't running any more.
Checklist
Closes:
DT-153How was this tested:
Timed Out,TerminatedorCanceledand there are pending activities