Allow using a custom asset path, overriding the embedded UI assets. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a config option to use a custom asset directory, replacing the bundled assets.
Why?
This makes it easy to test UI changes with
server start-dev.Checklist
Closes
How was this tested:
Tested via Temporal CLI PR:
./temporal server start-dev --ui-asset-path $PWD/../ui/.vercel/output/static/versus./temporal server start-dev. Confirmed the adjusted UI is served when the option is passed.Any docs updates needed?
No.