Add Nexus links tests #1613
Draft
Add Nexus links tests #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Aug 29, 2024
Comment on lines
+579
to
+588
| require.Equal(t, tc.testConfig.Namespace, link.GetWorkflowEvent().GetNamespace()) | ||
| require.Equal(t, handlerWfID, link.GetWorkflowEvent().GetWorkflowId()) | ||
| require.NotEmpty(t, link.GetWorkflowEvent().GetRunId()) | ||
| requireProtoEqual( | ||
| t, | ||
| &common.Link_WorkflowEvent_EventReference{ | ||
| EventType: enums.EVENT_TYPE_WORKFLOW_EXECUTION_STARTED, | ||
| }, | ||
| link.GetWorkflowEvent().GetEventRef()) | ||
| handlerRunID := link.GetWorkflowEvent().GetRunId() |
There was a problem hiding this comment.
nit: you could have just used requireProtoEqual on the entire struct.
There was a problem hiding this comment.
I cannot because I don't have the handler run id.
bergundy
reviewed
Aug 29, 2024
| @@ -290,10 +298,22 @@ func TestNexusWorkflowRunOperation(t *testing.T) { | |||
|
|
|||
| nc := tc.newNexusClient(t, service.Name) | |||
|
|
|||
| link := &common.Link_WorkflowEvent{ | |||
There was a problem hiding this comment.
This is redundant IMHO since we're already testing adding links from a workflow.
bergundy
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
I missed this in the last PR but please mark these functions as experimental in a different PR since this one has to remain a draft until we have a CLI with server 1.26.
https://github.com/temporalio/sdk-go/blob/master/temporalnexus/link_converter.go#L65-L89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add Nexus links tests
Why?
Checklist
Closes
How was this tested: