Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DisableStickyExecution #1464

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove DisableStickyExecution #1464

merged 1 commit into from
May 10, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Remove DisableStickyExecution, this flag has done nothing for 4 years and is time to remove since it causes confusion.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 10, 2024 18:02
@dandavison dandavison mentioned this pull request May 10, 2024
Closed
dandavison
dandavison approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was just confused by this for a while today. I saw the deprecation notice, but it didn't occur to me that it actually might do nothing.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit c69831e into temporalio:master May 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison approved these changes

@cretz cretz cretz approved these changes

@mfateev mfateev mfateev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quinn-With-Two-Ns @dandavison @cretz @mfateev