Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require update handler to have a context #1457

Merged
merged 2 commits into from
May 9, 2024
Merged

Require update handler to have a context #1457

merged 2 commits into from
May 9, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Require update handler to have a context as the first parameter.

Note this is a breaking change

closes: #1455

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 8, 2024 23:38
cretz
cretz approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to make this very clear in release notes. This is going to cause some current users some issues for sure and they won't know it until their workflow starts failing (we don't panic we return an error on invalid signature).

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 386a6d3 into temporalio:master May 9, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update handler should require workflow.Context as first parameter
2 participants
@Quinn-With-Two-Ns @cretz