Option to redirect devserver stdout/stderr to a file #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `StdoutLogFile` option to `DevServerOptions` that if it's not "" will redirect the spawned server stdout and stderr to this file.
|
|
cretz
reviewed
Apr 30, 2024
testsuite/devserver.go
Outdated
| @@ -77,6 +77,8 @@ type DevServerOptions struct { | |||
| LogLevel string | |||
| // Additional arguments to the dev server. | |||
| ExtraArgs []string | |||
| // Where to redirect stdout and stderr, if empty they will be redirected to the current process. | |||
| StdoutLogFile string | |||
There was a problem hiding this comment.
Suggested change
| StdoutLogFile string | |
| Stdout io.Writer | |
| Stderr io.Writer |
This is a more flexible approach, the caller can provide a file if they want.
There was a problem hiding this comment.
Agree, will update the PR soon-ish. Thanks.
cretz
approved these changes
May 1, 2024
There was a problem hiding this comment.
This looks good to me, will let @Quinn-With-Two-Ns take a peek
Quinn-With-Two-Ns
approved these changes
May 1, 2024
|
Thanks! |
|
Thanks @cretz ! Can you guestimate when you're going to tag a new version? |
|
@Quinn-With-Two-Ns what's the policy around when to cut a new version? Thanks |
daabr
added a commit
to autokitteh/autokitteh
that referenced
this pull request
Jun 18, 2024
No functional change in AK, but: - New Temporal SDK (ENG-820) - includes Miki's temporalio/sdk-go#1452 (follow-up in separate PR) - Many proto & test changes due to newly-working Buf validation checks in messages and services (which were silently violated until now) - Removed usage of `shortuuid` (replaced with a TypeID without a prefix) - Replaced direct usage of YAML v2 parsing with v3 Follow-up in separate PRs: - ENG-1024 - ENG-1026 - ENG-1027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
StdoutandStderroptions toDevServerOptionsthat if it's notnilwill redirect the spawned server stdout and stderr to them.What was changed
Option to redirect devserver stdout/stderr to different streams.
Add a
StdoutandStderroptions toDevServerOptionsthat if it's notnilwill redirect the spawned server stdout and stderr to this file.
Why?
We're embedding the dev server in out app, and when we close it we get huge amount of logs from the underlying dev server.
Checklist
Closes
How was this tested:
Ran the current tests.
Maybe https://docs.temporal.io/dev-guide/go/testing, not sure.