Rename namespace register -> create #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robholland
requested changes
Jan 23, 2023
| @@ -33,7 +33,7 @@ func NewNamespaceCommands() []*cli.Command { | |||
| }, | |||
| }, | |||
| { | |||
| Name: "register", | |||
There was a problem hiding this comment.
We should probably add register as an alias to avoid breaking existing docs etc.
There was a problem hiding this comment.
good point, updated
namespace/namespace.go
Outdated
| @@ -33,7 +33,7 @@ func NewNamespaceCommands() []*cli.Command { | |||
| }, | |||
| }, | |||
| { | |||
| Name: "register", | |||
| Name: "create", | |||
| Usage: "Register a new Namespace", | |||
| Flags: registerNamespaceFlags, | |||
There was a problem hiding this comment.
Flags variable should be renamed to createNamespaceFlags
robholland
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Renamed
temporal operator namespace register->temporal operator namespace createWhy?
Consistency with other commands and Temporal Cloud UI
Checklist
Closes
How was this tested:
updated tests