Add workflow update start and workflow update execute subcommands
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
597-workflow-update
branch
3 times, most recently
from
402942a
to
0ea3afe
Compare
dandavison
changed the title
workflow update start, create workflow update execute subcommandworkflow update start, and workflow update execute subcommands
dandavison
changed the title
workflow update start, and workflow update execute subcommandsworkflow update start and workflow update execute subcommands
dandavison
force-pushed
the
597-workflow-update
branch
from
0ea3afe
to
b618785
Compare
dandavison
commented
Aug 28, 2024
| ### temporal workflow update execute: Send an Update and wait for it to complete | ||
| Send a message to a Workflow Execution to invoke an Update handler, and wait for | ||
| the update to complete or fail. You can also use this to wait for an existing | ||
| update to complete, by submitting an existing update ID. |
There was a problem hiding this comment.
The last sentence will be changed when #647 is implemented.
dandavison
force-pushed
the
597-workflow-update
branch
from
b618785
to
292f8dc
Compare
cretz
reviewed
Aug 28, 2024
dandavison
force-pushed
the
597-workflow-update
branch
from
0f020db
to
f828326
Compare
dandavison
commented
Aug 28, 2024
cretz
approved these changes
Aug 28, 2024
dandavison
force-pushed
the
597-workflow-update
branch
from
f81dbf6
to
f0d61c4
Compare
cretz
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #597
This PR changes the CLI API so that
workflow updateis not itself a leaf command, but has two leaf subcommands:startandexecute. Previously,workflow updatehad the behavior of what is nowworkflow update, so this is a breaking change to the not-yet-GA workflow update feature.workflow update startwill output the update ID. In order to block and fetch the result of the update, users can doworkflow update executepassing the started update ID. See #647 for relevant plans to evolve the CLI update API, creating a new way to fetch the result.How this was tested