-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making tq stats visible from cli #638
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
78f2df8
Making tq stats visible from cli
Shivs11 2cd8dc1
Addressed comments and cleaned up unit tests
Shivs11 c8a3059
changed to --disable-stats with default value as false
Shivs11 8a1af2b
fix breaking unit-test
Shivs11 ee19bdc
trying to solve unit test breaking on windows
Shivs11 9b4dcfa
restored unit test to how it was previously
Shivs11 e85cd84
Removed and made a stricter check
Shivs11 c381d96
Corrected test
Shivs11 1bbd4f1
fixing a bug in the test
Shivs11 13c5815
removing validating BacklogIncreaseRate since it could be 0 in some c…
Shivs11 aa62070
Separating TqStats from Pollers
Shivs11 b7b7117
Delete temporalcli/flake_tester.sh
Shivs11 4ddb3be
Restored older comment
Shivs11 d94ac25
changed backlogAge type to string + made unit tests better
Shivs11 7271406
Refactored and altered Long and Short descriptions for describe command
Shivs11 200e6ca
PR feedback
Shivs11 99d6255
Removed redundancy in description
Shivs11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part of the sentence is only about reachability and it should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, however we should have the part :
the requested versions and all task types
.All in all, the sentence should look like:
The temporal task-queue describe command provides poller information, backlog statistics and task reachability (experimental) information for the requested versions and task types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"information" seems redundant?