Tweak server start-up text #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 15, 2024
temporalcli/commands.go
Outdated
| @@ -394,6 +394,10 @@ func (c *TemporalCommand) initCommand(cctx *CommandContext) { | |||
| } | |||
| } | |||
|
|
|||
| func VersionString() string { | |||
| return fmt.Sprintf("CLI %s (Server %s, UI %s)", Version, headers.ServerVersion, version.UIVersion) | |||
There was a problem hiding this comment.
Arguably we shouldn't show UI version if they haven't enabled the UI, but no big deal
temporalcli/commands.server.go
Outdated
| @@ -144,11 +144,12 @@ func (t *TemporalServerStartDevCommand) run(cctx *CommandContext, args []string) | |||
| return err | |||
| } | |||
|
|
|||
| cctx.Printer.Printlnf("%-16s %v:%v", "Temporal server:", toFriendlyIp(opts.FrontendIP), opts.FrontendPort) | |||
| cctx.Printer.Printlnf(VersionString() + "\n") | |||
There was a problem hiding this comment.
Suggested change
| cctx.Printer.Printlnf(VersionString() + "\n") | |
| cctx.Printer.Printlnf("%v\n", VersionString()) |
This is technically safer if there are accidentally any printf components in the version string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another iteration of tweaking the start-up message:
Was:
Becomes: