Supported flattened event detail view on workflow show/execute #615
Conversation
| } else { | ||
| s.Contains(output, "WorkflowExecutionSignaled") | ||
| } |
There was a problem hiding this comment.
This would show up in both output kinds, right? Non-detailed on the line, and detailed in the section header.
There was a problem hiding this comment.
Yes, but before this the test tested nothing about non-detailed event output, so I just thought I'd add it in an else for code clarity reasons (I can do better assertions on detailed). But I can move it out of else.
There was a problem hiding this comment.
Yeah I'd just assert it either way
| sort.Slice(fields, func(i, j int) bool { return fields[i].field < fields[j].field }) | ||
| return fields, nil |
There was a problem hiding this comment.
For arrays, will sorting do alphabetical sort as opposed to numerical "7" > "10"
There was a problem hiding this comment.
It might, good catch! I will fix this and add a test for it.
|
Once stabilized, maybe add it to the new help to promote it? |
What was changed
--event-detailsfromworkflow showandworkflow executethat, in text mode, blindly dumped full event in table column in an unreadable way--detailedtoworkflow showandworkflow executethat, for text output, dumps events as sections--followforworkflow show) still supportedBefore with something like
temporal workflow show -w my-wf --event-details:(note how bad this would be wrapping in a terminal)
After with something like
temporal workflow show -w my-wf --detailed:Note, the table form still exists for non
--detailed. Also note that we can continually tweak this post-merge, don't need to block merge for little pieces.Checklist
workflow showDetails more readable #546