Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize --name and --type flags on workflow commands #580

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Normalize --name and --type flags on workflow commands #580

merged 3 commits into from
Jun 5, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented May 30, 2024

What was changed

  • Added support new Alias option for command options
  • Added --name as an alias for --type for all workflow start/execute commands. --type is clearer for workflow start IMO.
  • Added --type as an alias for --name for all workflow interaction commands (signal, query, update). --name is clearer for these IMO.
  • Made sure option descriptions mention if they are required and what their aliases are.

Checklist

  1. Closes [Bug] Decide on --name vs --type and use consistently. #475

@cretz cretz requested a review from a team May 30, 2024 19:29
@cretz cretz merged commit 1f63231 into main Jun 5, 2024
7 checks passed
@cretz cretz deleted the name-and-type-normalize branch June 5, 2024 20:37
@antlai-temporal antlai-temporal mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-berry josh-berry josh-berry approved these changes

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Decide on --name vs --type and use consistently.
3 participants
@cretz @josh-berry @Quinn-With-Two-Ns