Print encoding of workflow results #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
commented
May 28, 2024
Comment on lines
141
to
142
| // TODO: The below fails seemingly due to a marshalling bug in api-go. The conversion of the | ||
| // returned raw payload in to JSON bytes is invalid json, and breaks the printing on this |
There was a problem hiding this comment.
I'm going to take a look at fixing this in api-go
There was a problem hiding this comment.
NM, apparently this is already fixed, by temporalio/api-go#159
There was a problem hiding this comment.
We just need to update versions when possible
There was a problem hiding this comment.
👍 Upon server release we will upgrade
Sushisource
changed the title
cretz
approved these changes
May 29, 2024
Comment on lines
141
to
142
| // TODO: The below fails seemingly due to a marshalling bug in api-go. The conversion of the | ||
| // returned raw payload in to JSON bytes is invalid json, and breaks the printing on this |
There was a problem hiding this comment.
👍 Upon server release we will upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT because it seems like tests are getting stuck but, nothing I changed should do that. Maybe just my machine.
What was changed
Print encoding of workflow results
Why?
To help the user understand what's going on in the event Result can't be decoded
Checklist
Closes [Feature Request] Add
ResultEncodingwhen printing workflow results that cannot be converted to shorthand JSON #547How was this tested:
Added UT
Any docs updates needed?