Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify go compiler minor version #563

Merged
merged 1 commit into from
May 16, 2024

Conversation

dandavison
Copy link
Contributor

What was changed?

Specify minor version of Go compiler

Why?

It's now required. See golang/go#65568. Without it on MacOS I get

go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

How did you test it?

go mod tidy && go build -o temporal ./cmd/temporal/main.go

@cretz
Copy link
Member

cretz commented May 16, 2024

At temporalio/sdk-go#1466 (comment), a simple go mod tidy fixed this by adding toolchain. But I'm fine with this too.

@dandavison
Copy link
Contributor Author

At temporalio/sdk-go#1466 (comment), a simple go mod tidy fixed this by adding toolchain. But I'm fine with this too.

cli(main) go mod tidy
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

@dandavison dandavison merged commit 83d4685 into temporalio:main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants