Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak server start text #554

Merged
merged 1 commit into from
May 9, 2024
Merged

Tweak server start text #554

merged 1 commit into from
May 9, 2024

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented May 9, 2024 •
edited
Loading

Before

$ temporal server start-dev
Temporal server is running at: localhost:7233
Web UI is running at: http://localhost:8233
Metrics available at: http://localhost:55053/metrics

After

$ temporal server start-dev
Temporal server: localhost:7233
Web UI:          http://localhost:8233
Metrics:         http://localhost:54941/metrics

dandavison
dandavison commented May 9, 2024
View reviewed changes
temporalcli/commands.server.go
@@ -101,11 +101,11 @@ func (t *TemporalServerStartDevCommand) run(cctx *CommandContext, args []string)
if friendlyIP == "127.0.0.1" {
friendlyIP = "localhost"
}
cctx.Printer.Printlnf("Temporal server is running at: %v:%v", friendlyIP, t.Port)
cctx.Printer.Printlnf("%-16s %v:%v", "Temporal server:", friendlyIP, t.Port)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be on board with something even cleaner here such as "Temporal" if others like that.

cretz
cretz approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I have no strong opinion on this output)

@dandavison dandavison merged commit f8c0fbd into temporalio:main May 9, 2024
7 checks passed
@antlai-temporal antlai-temporal mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandavison @cretz