Allowing configuring UI codec URL via flag #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robholland
approved these changes
Dec 13, 2022
bergundy
reviewed
Dec 14, 2022
server/ui.go
Outdated
| TemporalGRPCAddress: c.TemporalGRPCAddress, | ||
| EnableUI: c.EnableUI, | ||
| Codec: uiconfig.Codec{ | ||
| Endpoint: c.CodecEndpoint, |
There was a problem hiding this comment.
yea the default value is empty. This means it's disabled
bergundy
reviewed
Dec 14, 2022
server/ui.go
Outdated
| return cfg, nil | ||
| } | ||
|
|
||
| type uiConfig struct { |
There was a problem hiding this comment.
Why not use uiconfig.Config instead of creating this new struct and renaming NewUIConfig to MergeWithConfigFile?
This is a bit confusing to me.
bergundy
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added flag
--ui-codec-endpointfor configuring codec endpoint used by UIcopy of temporalio/temporalite-archived#174
resolve #52
Why?
enables the use of codec via a single run comand
Checklist
Closes
How was this tested:
Manually