Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator search-attribute commands #470

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add operator search-attribute commands #470

merged 1 commit into from
Feb 20, 2024

Conversation

yiminc
Copy link
Member

@yiminc yiminc commented Feb 18, 2024

What was changed

Add operator search-attribute commands

Why?

Add commands to operate search attributes

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

cretz
cretz reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just little things

temporalcli/commands.operator_search_attribute.go Outdated Show resolved Hide resolved
temporalcli/commands.operator_search_attribute.go Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
temporalcli/commandsmd/commands.md Outdated Show resolved Hide resolved
temporalcli/commands.operator_search_attribute.go Outdated Show resolved Hide resolved
temporalcli/commands.operator_search_attribute.go Show resolved Hide resolved
temporalcli/commands.operator_search_attribute.go Outdated Show resolved Hide resolved
cretz
cretz reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor note about test name on go test example (didn't test with unqualified name)

CONTRIBUTING.md Outdated Show resolved Hide resolved
@yiminc yiminc merged commit a9aa84d into temporalio:cli-rewrite Feb 20, 2024
5 checks passed
@josh-berry josh-berry mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yiminc @cretz