Add workflow stack command
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Feb 15, 2024
| case "not_completed_cleanly": | ||
| queryRejectCond = enums.QUERY_REJECT_CONDITION_NOT_COMPLETED_CLEANLY | ||
| default: | ||
| return fmt.Errorf("invalid query reject condition: %v, valid values are: 'not_open', 'not_completed_cleanly'", rejectCondition) |
There was a problem hiding this comment.
In theory with how string-enum works this should never get this far, but I support the default anyways
| return fmt.Errorf("invalid query reject condition: %v, valid values are: 'not_open', 'not_completed_cleanly'", rejectCondition) | ||
| } | ||
|
|
||
| result, err := cl.WorkflowService().QueryWorkflow(cctx, &workflowservice.QueryWorkflowRequest{ |
There was a problem hiding this comment.
Mentioned in other review, and don't have to change, but this could use the high-level QueryWorkflowWithOptions (changing buildRawInputPayloads to buildRawInput), but no big difference.
cretz
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
workflow stackcommand. Looks just likequeryoutput. In the future we should probably do a better job of formatting this, but it's not simple. Probably makes the most sense with enhanced trace.Why?
Part of cli rewrite.
Checklist
Closes
How was this tested: