Override SDK-set headers for client name and others #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
client-headers
branch
from
a811ade
to
46c677a
Compare
Sushisource
approved these changes
Feb 13, 2024
| md.Set("client-name", "temporal-cli") | ||
| md.Set("client-version", Version) | ||
| md.Set("supported-server-versions", ">=1.0.0 <2.0.0") | ||
| md.Set("caller-type", "operator") |
There was a problem hiding this comment.
It gives calls made by the CLI higher priority over application code.
This helps troubleshoot issues when you're getting rate limited for example.
bergundy
approved these changes
Feb 14, 2024
cretz
commented
Feb 14, 2024
| ) | ||
|
|
||
| // Capture from server | ||
| // TODO(cretz): Pending fix on server for gRPC interceptors |
There was a problem hiding this comment.
temporalio/temporal#5414 is the fix for those curious (added after this code was written, so not in the comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add
client-name,client-version,supported-server-versions, andcaller-typeheaders on outbound client calls in CLI refresh code. Previous CLI used outgoing gRPC metadata on the context, but my research has shown we overwrite that anyways. So up until now we may not have been setting these headers properly (making CLI appear as Go SDK).Checklist