Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Refresh: Implement workflow reset #443

Merged
merged 12 commits into from
Feb 15, 2024
Merged

CLI Refresh: Implement workflow reset #443

merged 12 commits into from
Feb 15, 2024

Conversation

tdeebswihart
Copy link
Contributor

@tdeebswihart tdeebswihart commented Feb 12, 2024 •
edited
Loading

What was changed

I've implemented the workflow reset command and tests for all its major functionality.

Batch reset functionality will come in a second PR after this one

@tdeebswihart tdeebswihart force-pushed the tds/workflow-reset branch 2 times, most recently from 47ff026 to 6faa14f Compare February 15, 2024 17:06
@tdeebswihart tdeebswihart marked this pull request as ready for review February 15, 2024 17:07
cretz
cretz reviewed Feb 15, 2024
View reviewed changes
temporalcli/client.go Outdated Show resolved Hide resolved
temporalcli/client.go Outdated Show resolved Hide resolved
temporalcli/client.go Outdated Show resolved Hide resolved
temporalcli/commands.workflow.go Show resolved Hide resolved
temporalcli/commands.workflow.go Outdated Show resolved Hide resolved
temporalcli/commands.workflow.go Outdated Show resolved Hide resolved
temporalcli/commands.workflow.go Outdated Show resolved Hide resolved
temporalcli/commands.workflow.go Outdated Show resolved Hide resolved
temporalcli/commands_test.go Outdated Show resolved Hide resolved
temporalcli/commands.workflow_test.go Outdated Show resolved Hide resolved
cretz
cretz approved these changes Feb 15, 2024
View reviewed changes
temporalcli/commands.workflow_reset.go Outdated Show resolved Hide resolved
@cretz
Copy link
Member

cretz commented Feb 15, 2024

Overall LGTM!

@tdeebswihart
Remove the unused resetTypesMap
cfcdeb3 
I was able to remove more of the old code than I expected
@tdeebswihart tdeebswihart merged commit f8db0c1 into cli-rewrite Feb 15, 2024
5 checks passed
@tdeebswihart tdeebswihart deleted the tds/workflow-reset branch February 15, 2024 19:25
@josh-berry josh-berry mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ast2023 ast2023 ast2023 left review comments

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdeebswihart @cretz @ast2023