Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workflow cancel command #435

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

tdeebswihart
Copy link
Contributor

What was changed

I implemented temporal workflow cancel, which should behave the same as in the existing CLI except for the same caveats/improvements as in #432

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cretz
Copy link
Member

cretz commented Feb 9, 2024

May have to resolve conflicts and regen commands to fix CI

@tdeebswihart tdeebswihart merged commit b98627b into cli-rewrite Feb 12, 2024
5 checks passed
@tdeebswihart tdeebswihart deleted the tds/workflow-cancel branch February 12, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants