Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI on linux and macOS #39

Merged
merged 5 commits into from
Dec 1, 2022
Merged

Fix CI on linux and macOS #39

merged 5 commits into from
Dec 1, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Nov 30, 2022 •
edited
Loading

What was changed

Updated GHA actions to their latest versions & tweaks

Why?

Fix CI

Checklist

  1. Closes

  2. How was this tested:

CI

  1. Any docs updates needed?

@feedmeapples feedmeapples changed the title Fix CI WIP Fix CI Nov 30, 2022
@feedmeapples feedmeapples mentioned this pull request Dec 1, 2022
Merged
@feedmeapples feedmeapples changed the base branch from main to update-module December 1, 2022 01:40
@feedmeapples feedmeapples changed the title WIP Fix CI Fix CI Dec 1, 2022
@bergundy
Copy link
Member

bergundy commented Dec 1, 2022

Why did you have to use 3.0.0 for the setup-go action?

@feedmeapples
Copy link
Contributor Author

feedmeapples commented Dec 1, 2022 •
edited
Loading

Why did you have to use 3.0.0 for the setup-go action?

copied the version from somewhere. Noticed now

@feedmeapples feedmeapples changed the base branch from update-module to main December 1, 2022 01:43
@feedmeapples feedmeapples changed the title Fix CI Fix CI on linux and macOS Dec 1, 2022
@feedmeapples feedmeapples merged commit 45205c4 into main Dec 1, 2022
@feedmeapples feedmeapples deleted the fix-ci branch December 2, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @bergundy