Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make env get and delete work for env and env prop #30

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Nov 22, 2022

What was changed

Changed env syntax to as following

Read env key

temporal env get local.namespace
  namespace  canary

Read env

temporal env get local
  address    127.0.0.1:7233  
  namespace  canary

Set env key

temporal env set local.namespace default
Set 'local.namespace' to: default

Delete env key

temporal env delete canary.namespace
Deleted env property: canary.namespace

Delete env entry

temporal env delete canary
Deleted env: canary

Why?

UX design decision

Checklist

  1. Closes

  2. How was this tested:

Updated unit tests and ran locally. There seems to be another unrelated issue when running in a GHA pipeline

  1. Any docs updates needed?

Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn’t look closely at the implementation

@feedmeapples
Copy link
Contributor Author

verified the unit tests pass

@feedmeapples feedmeapples merged commit 6437ddf into main Nov 30, 2022
@feedmeapples feedmeapples deleted the update-env-syntax branch December 2, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants