Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch workflow delete #201

Merged
merged 2 commits into from
May 11, 2023
Merged

Add batch workflow delete #201

merged 2 commits into from
May 11, 2023

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Apr 18, 2023

What was changed

Update temporal workflow delete adding option to perform a batch operation using --query filter

resolve #55

Why?

Supporting batch delete for workflows

Checklist

  1. Closes

  2. How was this tested:

new E2E test TestWorkflowDelete_Batch WIP

  1. Any docs updates needed?

@cretz
Copy link
Member

cretz commented Apr 19, 2023

Hrmm, I wonder if there's a usability concern with single workflow calls and multi-workflow calls being separated only by --query. Also, can you confirm that with --yes this prompts the user to confirm?

@feedmeapples
Copy link
Contributor Author

It prompts when --yes is not passed. About the usability: we've ended up with filter options such as --workflow-id + --run-id, --query are in a single command instead of multiple after internal discussions, the prompt and good --query flag should be enough? So far haven't seen/heard from people running into issues with --query flag

The prompt is shown by default when --yes is not passed. --yes auto-confirms the prompts

@feedmeapples feedmeapples force-pushed the batch-delete branch 2 times, most recently from ec97af2 to a4b452b Compare May 11, 2023 18:55
@feedmeapples feedmeapples merged commit 3a71085 into main May 11, 2023
@feedmeapples feedmeapples deleted the batch-delete branch May 11, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] delete command should support batch mode when given a query
3 participants