Test installation in zsh and fish shells #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
changed the title
feedmeapples
changed the title
feedmeapples
force-pushed
the
zsh
branch
3 times, most recently
from
e2be8c0
to
2d942a8
Compare
robholland
approved these changes
Mar 9, 2023
cretz
reviewed
Mar 9, 2023
.github/workflows/ci.yml
Outdated
| run: sh -c '${{ matrix.shell }} -c "./install.sh"' | ||
| - name: Install ${{matrix.shell}} using apt-get | ||
| if: matrix.os == 'ubuntu-latest' && matrix.shell != 'sh' | ||
| run: "sudo apt-get install -y ${{ matrix.shell }}" |
There was a problem hiding this comment.
Can you do something at the end to confirm installed?
.github/workflows/ci.yml
Outdated
|
|
||
| test-install: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| shell: [sh, bash, zsh] | ||
| shell: [sh, bash, zsh, fish] |
There was a problem hiding this comment.
You should not do these (just) by "shell" you should (also) do them also by "approach". In many cases the shell does not matter.
.github/workflows/ci.yml
Outdated
| run: "brew update && brew install ${{ matrix.shell }}" | ||
|
|
||
| - name: Update SHELL env variable | ||
| run: "env SHELL=$(which ${{ matrix.shell }})" |
There was a problem hiding this comment.
Should we be using https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell instead?
There was a problem hiding this comment.
i've tried this though have been running into syntax issues with shell: ${{ .. }} approach. Hardcoding the shells worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Testing install .sh script in zsh and fish
Why?
testing zsh & fish, getting the green checkmark for CI
Checklist
Closes
How was this tested:
CI