[Bug] Sqlite pragmas are not applied correctly

[vbehar]

What are you really trying to do?

I'm trying to start a dev-server with specific sqlite settings (pragma), for example to enable WAL journal

Describe the bug

• The parameters set on the CLI are not applied to the sqlite database
• Temporal CLI doesn't support all pragma statements supported by sqlite

Minimal Reproduction

• temporal server start-dev --db-filename temporal.sqlite --sqlite-pragma journal_mode=WAL

this should create 3 files:

• temporal.sqlite
• temporal.sqlite-shm
• temporal.sqlite-wal

but only 1 is created: temporal.sqlite - which means that the journal_mode=WAL pragma statement has not been applied to the sqlite DB

also, not all pragma statements supported by sqlite in https://www.sqlite.org/pragma.html are accepted by temporal CLI. the CLI only support 2 statements: journal_mode and synchronous.

Environment/Versions

• Temporal CLI Version: v1.1.0

Additional context

• this code: https://github.com/temporalio/cli/blob/v1.1.0/temporalcli/devserver/server.go#L324-L329 accepts only 2 statements, but it's not clear why. I don't see any reason to restrict only to these 2...
• this line https://github.com/temporalio/cli/blob/v1.1.0/temporalcli/devserver/server.go#L330 adds an underscore _ to the pragma key, but the sqlite plugin doesn't remove it before building the DSN https://github.com/temporalio/temporal/blob/release/v1.23.x/common/persistence/sql/sqlplugin/sqlite/plugin.go#L205 so we end up with an sqlite URL similar to temporal.sqlite?_pragma=_journal_mode=WAL instead of temporal.sqlite?_pragma=journal_mode=WAL

[cretz]

Thanks! Looking at PR.